Awesome @jeffreyflynt I will review after the weekend. @bratelefant this might be interesting to you, too

It looks as if there were some linting issues, I fixed those and pushed another commit.

@jeffreyflynt I'll need a bit more time because I need to complete Meteor 3.0 migration with this package

@jeffreyflynt I'll need a bit more time because I need to complete Meteor 3.0 migration with this package

I can make a PR for said migration as I had done this for myself if that will help; unless you have already begun.

@jeffreyflynt yes I already did that but didn't publish or push as I wanted to test locally first. I now made it public via #21 and also released leaonline:[email protected].

You can review it if you like. In the meantime I will check on your PR what I can do to get the tests fixed.

Thanks. I fixed the issue that was causing the tests to fail. I added id to the return of getClient. I removed that.

@jeffreyflynt I would merge this into the current branch and release another Meteor 2.x compatible version with your contribution. For the #21 there needs to be a Meteor 3 compatible implementation. If you want I can add this to #21 but I'm also fine if you want to do it

Hey @jeffreyflynt, how are you?
I wonder why we added the id field on retrieving client, but then change was rolled back: 4526117#diff-e58997fdbe2b8e4535e2dde27b344afe6f1bbf2aabecfbfdfd10727167a883a6R57
I ask because I'm having an issue on this exact point as node-oauth2-server tries to validate clientIds using field client.id but it is not matching as on client collection is saved as clientId.

Hi @MaxwelSant ,

I am not fully sure tbh. @jankapunkt implemented it back in, in the current open PR. You could add this code block to your code to get this working:

Hi @MaxwelSant @jeffreyflynt the clientDoc.id is actually clientDoc.clientId but since you could theoretically save any other data, including an abitrary id value, it would get overridden by the former code.

However maybe I was thinking too strong in terms of abstraction and noone will ever come into that usecase?